Change the Link implementation in Google Provider #51576
Merged
potiuk merged 1 commit intoapache:mainfrom Jun 18, 2025
Merged
Conversation
molcay
force-pushed
the
refactor-links-for-google-provider
branch
from
325310c to
96d6a17
Compare
Contributor
|
Hi @potiuk ! |
Member
|
Ineed huge change but easy to review as most of it is the same. Currently Conflicts need to be resolved but I already reviewed it and it's good to go as long as CI agrees. |
potiuk
approved these changes
Jun 17, 2025
molcay
force-pushed
the
refactor-links-for-google-provider
branch
3 times, most recently
from
3c82acd to
0bd7a35
Compare
…nd compatible with Airflow 3
molcay
force-pushed
the
refactor-links-for-google-provider
branch
from
0bd7a35 to
e30bdeb
Compare
Contributor
Author
|
@potiuk, I think the CI is finally green :) |
Member
|
🎉 |
9 tasks
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jun 21, 2025
…nd compatible with Airflow 3 (apache#51576)
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will change the Link implementation in Google Provider to make it clean.
The PR consists of the following:
persistmethod to the base class.extra_links_paramsmethod in the operator level to pass static arguments (project_id,location, etc) to the link^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.